svn commit: samba r8493 - branches/SAMBA_3_0/source/lib trunk/source/lib

[Guenther Deschner]

Hi Jerry,

On Fri, Jul 15, 2005 at 01:24:22PM -0500, Gerald (Jerry) Carter wrote:
> > According to MSKB 141714 the %LOGONSERVER% variable should be
> > substituted like our %L-variable.
> 
> >  		case 'L' : 
> > -			if (local_machine_name && *local_machine_name)
> > +			if (local_machine_name && *local_machine_name) {
> > +				if (IS_DC)
> > +					string_sub(p, "\%LOGONSERVER\%", local_machine_name, l);
> >  				string_sub(p,"%L", local_machine_name,l); 
> > -			else {
> > +			} else {
> 
> Guenther,
> 
> For some reason this makes me feel icky.  I know why you are doing it
> but I'd rather see a generic means of support long name variables
> using a consistent syntax.  Care to discuss this some more?

Of course. After re-reading the very poor docs, I think we just should
make sure to not substitute that variable *at all*. As abartlet correctly
pointed out, it's scope is limited to the workstation where a user has
logged on. I do some testing and then inverse the patch.

Cheers,
Guenther

-- 
Günther Deschner                    GPG-ID: 8EE11688
Novell / SUSE LINUX                       gd at suse.de
Samba Team                              gd at samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20050719/83683b72/attachment.bin