svn commit: samba r8493 - branches/SAMBA_3_0/source/lib trunk/source/lib

[Andrew Bartlett]

On Fri, 2005-07-15 at 13:24 -0500, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> > According to MSKB 141714 the %LOGONSERVER% variable should be
> > substituted like our %L-variable.
> 
> >  		case 'L' : 
> > -			if (local_machine_name && *local_machine_name)
> > +			if (local_machine_name && *local_machine_name) {
> > +				if (IS_DC)
> > +					string_sub(p, "\%LOGONSERVER\%", local_machine_name, l);
> >  				string_sub(p,"%L", local_machine_name,l); 
> > -			else {
> > +			} else {
> 
> Guenther,
> 
> For some reason this makes me feel icky.  I know why you are doing it
> but I'd rather see a generic means of support long name variables
> using a consistent syntax.  Care to discuss this some more?

This seems odd to me too, but for a different reason.  I always assumed
that this was evaluated on the client side, as a windows environment
variable.

Can someone show this being set on SAMR, but being different in a
netlogon reply, or some other way to show that the server munges it?

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Samba Developer, SuSE Labs, Novell Inc.        http://suse.de
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20050716/b7961547/attachment.bin