Samba4: pvfs_change_create_options holds lock too long?

Volker Lendecke Volker.Lendecke at SerNet.DE
Sat Jul 9 10:18:37 GMT 2005


In pvfs_change_create_options I don't see a talloc_free at the end. Eventually
it's cleaned up at the end of the request as it's a child of req, but I don't
see why the lock on the share mode db has to be held longer than this routine
is run.

Is this patch correct?


Index: ntvfs/posix/pvfs_open.c
--- ntvfs/posix/pvfs_open.c	(Revision 8244)
+++ ntvfs/posix/pvfs_open.c	(Arbeitskopie)
@@ -1258,6 +1258,8 @@
 		f->handle->create_options = create_options;
+	talloc_free(lck);
 	return status;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url :

More information about the samba-technical mailing list