svn commit: samba r8178 - in trunk/source/smbd: .

Jeremy Allison jra at
Wed Jul 6 11:52:18 GMT 2005

On Wed, Jul 06, 2005 at 08:20:08AM +0000, vlendec at wrote:
> Author: vlendec
> Date: 2005-07-06 08:20:06 +0000 (Wed, 06 Jul 2005)
> New Revision: 8178
> WebSVN:
> Log:
> Make Samba3 pass the new delete-on-close test.
> Jeremy, I'm not sure this is the right way to do it, please review.

This could be extremely costly to check on every qpathinfo. Clients
do qpathinfo a *lot*. Can you use cachegrind and work out the
percent cost to check this ? We might be able to do a version
that just checks the share modes on files this process has open
at much less cost than doing the system calls to lock / read /
then unlock the db.

We've been running fine for a very long time without these
semantics, so I'd prefer to have this code present but #ifdef'ed
out for now until we know the real cost.

I'll #ifdef that if it's ok for now - let's get some real
numbers on this. There's no sense in having 100% semantics
if (a) it's something no clients actually care about (ie. no
apps depend on it) and (b) it makes us 10% slower....


More information about the samba-technical mailing list