svn commit: samba r8148 - in branches/SAMBA_4_0/source: auth/kerberos include librpc librpc/idl librpc/ndr torture/auth

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bartlett schrieb:
> On Mon, 2005-07-04 at 15:42 +0000, metze at samba.org wrote:
> 
>>Author: metze
>>Date: 2005-07-04 15:42:08 +0000 (Mon, 04 Jul 2005)
>>New Revision: 8148
>>
>>WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=8148
>>
>>Log:
>>- make the PAC generation code a bit more readable and add some outof memory checks
>>
>>- move to handmodified pull/push code for PAC_BUFFER
>>  to get the _ndr_size field and the subcontext size right
> 
> 
> I don't think we are doing that right yet.  Remember, the problem is
> that the subcontext is padded behind, but the size in the structure is
> not rounded, it is the real size of the NDR data contained within.

it is rounded for the LOGON_INFO but not for the other fields,

and I have changed the ndr_push_unique_ptr() to use this algorithm
ptr = ndr->ptr_count * 4;
ptr |= 0x00020000;
ndr->ptr_count++;

and
the ndr_pull_PAC_DATA() ndr_push_PAC_DATA() run on the sample PAC created
the same DATA_BLOB.
(except two netr_String fields in the netr_SamInfo3 doesn't have size==length)

the sizes and offset and padding in PAC_BUFFER was correct.
(I also tested with another sample w2k3 PAC)


- --
metze

Stefan Metzmacher <metze at samba.org> www.samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3-nr1 (Windows XP)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCyhHom70gjA5TCD8RAi12AJ9NQl4JchQAE8MKWvt2wUF+aNadAgCfcmR1
n+ZVgCBUE5WnFEAd7JNXO50=
=Uio2
-----END PGP SIGNATURE-----