svn commit: samba r8111 - in branches/SAMBA_4_0/source: include libcli/raw libcli/util

[Andrew Bartlett]

On Mon, 2005-07-04 at 02:54 +0000, tridge at samba.org wrote:
> Author: tridge
> Date: 2005-07-04 02:54:32 +0000 (Mon, 04 Jul 2005)
> New Revision: 8111
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=8111
> 
> Log:
> fixed the client library to work against w2k3 with nt status codes
> disabled. The main change is to turn off spnego, which cannot work at
> all without nt status codes (w2k3 gives a ERRHRD:ERRgeneral error when
> you try)

This is a fun one, but Samba servers have always supported it. 

> I also modified NT_STATUS_EQUAL() to allow for nt->dos code equality,
> but only when nt status codes are disabled in smb.conf. That keeps all
> the existing torture code working, while still allowing us to
> correctly catch the cases where forced dos error codes are needed

Why only when disabled in the smb.conf?  Why not always, given that an
arbitrary server might not support NTSTATUS codes on the wire?

> The dos->ntstatus mapping table has been removed completely, as it
> doesn't really make sense, is impossible to get right, and with the
> new dos status handling isn't needed. When matching a nt status code
> to a dos status code it makes far more sense to map from the nt code
> to the dos code and compare, rather than the reverse, as the nt->dos
> mapping is what windows has to do internally, so there really is a
> valid mapping table.

This sounds like a very worthwhile improvement.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Samba Developer, SuSE Labs, Novell Inc.        http://suse.de
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20050704/5abad53d/attachment.bin