svn commit: samba r4917 - in branches/SAMBA_3_0/source: lib libsmb utils

Jeremy Allison jra at samba.org
Sat Jan 22 23:23:35 GMT 2005


On Sat, Jan 22, 2005 at 09:13:58PM +0100, Guenther Deschner wrote:
> Hi Jeremy,
> 
> On Sat, Jan 22, 2005 at 01:22:40AM +0000, jra at samba.org wrote:
> ,,,
> > Merge some of Derrell.Lipman at UnwiredUniverse.com obvious fixes.
> > Added text explaining units in pdbedit time fields.
> > Jeremy.
> ...
> > Modified: branches/SAMBA_3_0/source/lib/account_pol.c
> > ===================================================================
> > --- branches/SAMBA_3_0/source/lib/account_pol.c	2005-01-22 00:52:54 UTC (rev 4916)
> > +++ branches/SAMBA_3_0/source/lib/account_pol.c	2005-01-22 01:22:39 UTC (rev 4917)
> > @@ -118,8 +118,8 @@
> >  	{AP_MIN_PASSWORD_LEN, "min password length"},
> >  	{AP_PASSWORD_HISTORY, "password history"},
> >  	{AP_USER_MUST_LOGON_TO_CHG_PASS, "user must logon to change password"},
> > -	{AP_MAX_PASSWORD_AGE, "maximum password age"},
> > -	{AP_MIN_PASSWORD_AGE,"minimum password age"},
> > +	{AP_MAX_PASSWORD_AGE, "maximum password age (seconds since 1970)"},
> > +	{AP_MIN_PASSWORD_AGE,"minimum password age (seconds since 1970)"},
> >  	{AP_LOCK_ACCOUNT_DURATION, "lockout duration"},
> >  	{AP_RESET_COUNT_TIME, "reset count minutes"},
> >  	{AP_BAD_ATTEMPT_LOCKOUT, "bad lockout attempt"},
> > 
> 
> I've reverted these with the passdb-account-policy-commit for two reasons.
> The format is actually just seconds and not seconds since 1.1.1970. And we
> shouldn't just change these strings (they are used to find policies in the
> tdb (and now ldap).

Ok, fair enough. I just wished we'd used more descriptive
strings - they currently are very opaque.

Jeremy.


More information about the samba-technical mailing list