nbt bug2?

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi tridge,

I think the goto failed; is a bug, if talloc_zero() fails we should not free a NULL pointer
there are other places with bugs like this in your latest patches...


	req = talloc_zero(nbtsock, struct nbt_name_request);
	if (req == NULL) goto failed;

...

	return req;

failed:
	talloc_free(req);
	return NULL;
}
- --
metze

Stefan Metzmacher <metze at samba.org> www.samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3-nr1 (Windows XP)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFB8UPCm70gjA5TCD8RAmzPAJ92hpRQ+KLyulm3huoEsa3xjKGUZACgjf2O
CcnY2ryv5DWtv8/DtM6Pw+Q=
=GfnK
-----END PGP SIGNATURE-----