samba, MIT krb5 1.4beta5 and HAVE_REGEX_H

[Andreas Hasenack]

I started getting build errors with samba-3.0.10. It seems only after
I upgraded kerberos do version 1.4beta-something.

(...)
Compiling client/clitar.c
client/clitar.c:91: error: syntax error before '*' token
client/clitar.c:91: warning: data definition has no type or storage class
client/clitar.c: In function `tar_parseargs':
client/clitar.c:1754: error: `regex_t' undeclared (first use in this function)
(...)

So, HAVE_REGEX_H was defined but regex.h never included. I think this definition
is comming from /usr/include/gssapi/gssapi.h and seems to be new for krb5-1.4beta
(at least for my build).

For now I added this to source/include/includes.h:
--- samba-3.0.10/source/include/includes.h~     2004-12-15 12:12:16.000000000 -0200
+++ samba-3.0.10/source/include/includes.h      2005-01-21 14:18:21.914824640 -0200
@@ -465,6 +465,10 @@
 #include <com_err.h>
 #endif

+#if HAVE_REGEX_H
+#include <regex.h>
+#endif
+
 #if HAVE_SYS_ATTRIBUTES_H
 #include <sys/attributes.h>
 #endif

Is this correct?