svn commit: samba r4785 - in branches/SAMBA_4_0/source: . script

Andrew Tridgell tridge at
Tue Jan 18 01:19:52 GMT 2005


 > I think I can do a lot of talloc_steal() or talloc_reference() now that
 > we moved ldb to talloc, that code has not changed when I made the
 > interim conversion to talloc.

a steal probably makes most sense, or just a pointer assignment if
you're keeping both contexts around for the same time.

 > The strdup where necessary as I search all the attributes for all the
 > schema referenced by the current operation and need to keep them around
 > while searching the tree 

I don't really understand why this requires a strdup. You can keep the
search results for as long as you need them, or steal bits of them if
you want to just keep some parts.

I'm not really so concerned about the speed of the strdup calls
(although that is a factor), its the fact that it forces you to add a
lot more error checking and bailout logic.

 > (1-2 search for each objectclass involved, no optimizations yet)

yep - we will need some optimisations once you've got it to the stage
of passing all our existing tests. How is that going btw? I imagine
you've probably hit quite a few places in our rpc server code where we
don't fill in all the required attributes :-)

Cheers, Tridge

More information about the samba-technical mailing list