svn commit: samba r4535 - in branches/SAMBA_4_0/source: build/pidl librpc/ndr

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Tridgell schrieb:
| Metze,
|
| Excellent work on the flags support in pidl!
|
| Only one minor glitch I noticed in your patch. You tidied up the
| ordering of the types in util::type_align(). They were deliberately
| out of order, with the most common types first, as it made a noticible
| difference in speed of compiling with pidl when I last did pidl
| tuning.
|
| I should have put a comment in explaining that :-)

thx:-)

If you want you can reorder them and add a comment

Notice, I'm currently working on a
'declare bitmap samr_AcctFlags;' statement in pidl
to allow forward declarations e.g. when we want to use this bitmap in the netlogon.idl

(I also add that for 'declare enum ...;'


- --
metze

Stefan Metzmacher <metze at samba.org> www.samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3-nr1 (Windows XP)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFB3NOkm70gjA5TCD8RAsIbAKDE3mB87f4FsZAMkpz2WoxA2GigrwCcDq7j
M+JC9zAWqx8cgnpgFUDOB+E=
=vbg3
-----END PGP SIGNATURE-----