[patch 3/3] get rid of two unnessesary assignments in fs/cifs/file.c

Jesper Juhl juhl-lkml at dif.dk
Wed Jan 5 22:31:28 GMT 2005

On Wed, 5 Jan 2005, Steven French wrote:

> The reason for the logic: 
>         rc = -EIO; 
>         FreeXid(xid); 
>         return rc; 
> rather than 
>         FreeXid(xid); 
>         return -EIO; 
> is mainly to simplify debugging.  When debugging is enabled at runtime
> (e.g. "echo 1 > /proc/fs/cifs/cifsFYI"), FreeXid will print the value of
> rc to dmesg as an informational message which helps in debugging.  In
> addition the FreeXid macro can be modified fairly easily when
> investigating problems to selectively take certain additional debug
> actions based on the rc.   
I see, just disregard my patch then.
Thank you for explaining.

Jesper Juhl

More information about the samba-technical mailing list