[patch] cifs: module_param fixes

Steven French sfrench at us.ibm.com
Wed Jan 5 00:13:41 GMT 2005


Ouch.

Thanks for catching that.  Have updated the code for this now in the 
project bk tree.


Steve French
Senior Software Engineer
Linux Technology Center - IBM Austin
phone: 512-838-2294
email: sfrench at-sign us dot ibm dot com



Domen Puncer <domen at coderock.org> 
12/29/2004 04:02 AM

To
sfrench at samba.org
cc
samba-technical at lists.samba.org
Subject
[patch] cifs: module_param fixes






Last parameter in module_param is file permission in sysfs (or 0, if
parameter is not exported).


Signed-off-by: Domen Puncer <domen at coderock.org>

--- c/fs/cifs/cifsfs.c           2004-12-25 15:50:20.000000000 +0100
+++ a/fs/cifs/cifsfs.c           2004-12-29 10:58:11.000000000 +0100
@@ -59,16 +59,16 @@ unsigned int ntlmv2_support = 0;
 unsigned int sign_CIFS_PDUs = 1;
 struct task_struct * oplockThread = NULL;
 unsigned int CIFSMaxBufSize = CIFS_MAX_MSGSIZE;
-module_param(CIFSMaxBufSize, int, CIFS_MAX_MSGSIZE);
+module_param(CIFSMaxBufSize, int, 0);
 MODULE_PARM_DESC(CIFSMaxBufSize,"Network buffer size (not including 
header). Default: 16384 Range: 8192 to 130048");
 unsigned int cifs_min_rcv = CIFS_MIN_RCV_POOL;
-module_param(cifs_min_rcv, int, CIFS_MIN_RCV_POOL);
+module_param(cifs_min_rcv, int, 0);
 MODULE_PARM_DESC(cifs_min_rcv,"Network buffers in pool. Default: 4 Range: 
1 to 64");
 unsigned int cifs_min_small = 30;
-module_param(cifs_min_small, int, 30);
+module_param(cifs_min_small, int, 0);
 MODULE_PARM_DESC(cifs_small_rcv,"Small network buffers in pool. Default: 
30 Range: 2 to 256");
 unsigned int cifs_max_pending = CIFS_MAX_REQ;
-module_param(cifs_max_pending, int, CIFS_MAX_REQ);
+module_param(cifs_max_pending, int, 0);
 MODULE_PARM_DESC(cifs_max_pending,"Simultaneous requests to server. 
Default: 50 Range: 2 to 256");
 
 



More information about the samba-technical mailing list