svn commit: samba r5409 - in branches/SAMBA_4_0/source/gtk: . common tools

Stefan (metze) Metzmacher metze at
Tue Feb 15 13:05:53 GMT 2005

Hash: SHA1

Jelmer Vernooij schrieb:
| Hi Metze,
| metze at wrote:
| | Log:
| | - add a gtk events plugin
| Thanks, Metze!
| | - this is used in our gtk apps
| | - make the main() functions of the gtk apps look
| |   more simular (we need to get rid of the globals
| |   in gregedit!)
| Some of the variables though not all imho (e.g. gregedit will never have
| multiple threads). There's no point in making gregedit overly
| complicated by putting variables that are specific to gregedit in
| structs and passing these around everywhere.

I think that passing context pointers makes it much more understandable
while reading the code! otherwise you always think "hmm where is that var comming from?..."
and that is much more complicated to understand for me...

I agree that some of the globals can stay.

But I think it would be very cool to support multiple connections at once.

so that you can easy switch between to server, when you're searching for differences.
or maybe a diff function would be cool...

- --

Stefan Metzmacher <metze at>
Version: GnuPG v1.2.3-nr1 (Windows XP)
Comment: Using GnuPG with Thunderbird -


More information about the samba-technical mailing list