svn commit: samba r5286 - in branches/SAMBA_4_0/source: build/pidl libcli/nbt librpc/ndr librpc/rpc ntvfs/ipc torture/rap

Andrew Tridgell tridge at
Thu Feb 10 00:45:45 GMT 2005


Thanks for doing this, though I wonder if you are testing the code
fully? For example, ncacn_ip_tcp seems to be broken now. I don't know
if its your recent commit or not, but I am certainly suspicious :-)

Perhaps you could run script/tests/ and
script/test/ after each pidl change to ensure its all

My apologies if the breakage of ncacn_ip_tcp isn't your fault.

I also think that you will need to add "if (ndr_flags & NDR_SCALARS)"
tests in all the scalar functions in ndr_basic.c. Otherwise as you
progress to making the calling of the ndr functions more generic you
will find that they will be called with NDR_BUFFERS, which would break
things completely.

Cheers, Tridge

More information about the samba-technical mailing list