[patch] Makefile.in tweaks for ldb
idra at samba.org
Sat Dec 31 09:42:42 GMT 2005
On Sat, 2005-12-31 at 08:44 +1100, Brad Hards wrote:
> On Friday 30 December 2005 23:01 pm, Simo wrote:
> > On Fri, 2005-12-30 at 22:56 +1100, Brad Hards wrote:
> > > On Friday 30 December 2005 22:49 pm, Simo wrote:
> > > > On Fri, 2005-12-30 at 19:45 +1100, Brad Hards wrote:
> > > > > The attached patch tweaks the ldb/Makefile.in to do a better job of
> > > > > cleaning up after make test, and provides a test-schema target to
> > > > > allow the tests to proceed to completion.
> > > >
> > > > Applied, but the make clean stuff only.
> > >
> > > Is there some problem with the test suite part?
> > I find not useful notifying about the fact that we disabled a test.
> > We will re-enable it when it is ok, it's just a devel option, no need to
> > make more verbose/disturbing output :)
> That isn't the point of the change. If you run "make test", then it will fail,
> test: $(BINS) test-tdb test-ldap test-sqlite3 test-schema
> However there is no target "test-schema". So the test target can never work.
All right, I'll apply your change.
> I don't see "make test" as just being for ldb developers - it is a confidence
> test for everyone that builds from source that the build is correct on the
> current platform. It should not fail gratuitously.
no it should not fail, thanks for pointing out, I had no time to test,
more time soon :-)
Simo Sorce - idra at samba.org
Samba Team - http://www.samba.org
Italian Site - http://samba.xsec.it
More information about the samba-technical