svn commit: samba r9440 - in branches/SAMBA_4_0/source/librpc/ndr: .

[Andrew Bartlett]

On Sun, 2005-08-21 at 00:07 +0000, jelmer at samba.org wrote:
> Author: jelmer
> Date: 2005-08-21 00:07:51 +0000 (Sun, 21 Aug 2005)
> New Revision: 9440
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=9440
> 
> Log:
> Fix bug introduced by new zero-padding code. Caught by the buildfarm.
> 
> Modified:
>    branches/SAMBA_4_0/source/librpc/ndr/ndr_string.c
> 
> 
> Changeset:
> Modified: branches/SAMBA_4_0/source/librpc/ndr/ndr_string.c
> ===================================================================
> --- branches/SAMBA_4_0/source/librpc/ndr/ndr_string.c	2005-08-20 23:36:43 UTC (rev 9439)
> +++ branches/SAMBA_4_0/source/librpc/ndr/ndr_string.c	2005-08-21 00:07:51 UTC (rev 9440)
> @@ -641,22 +641,25 @@
>  
>  NTSTATUS ndr_push_charset(struct ndr_push *ndr, int ndr_flags, const char *var, uint32_t length, uint8_t byte_mul, int chset)
>  {
> -	ssize_t ret;
> -	NDR_PUSH_NEED_BYTES(ndr, byte_mul*length);
> +	ssize_t ret, required;
> +
> +	required = byte_mul * length;
> +	

Is there a problem with integer overflow here?

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Samba Developer, SuSE Labs, Novell Inc.        http://suse.de
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20050821/2854ace3/attachment.bin