svn commit: samba r9314 - in branches/SOC/SAMBA_4_0: . source/libnet source/torture/rpc

Andrew Bartlett abartlet at
Tue Aug 16 04:44:42 GMT 2005

On Tue, 2005-08-16 at 01:53 +0000, brad at wrote:
> Author: brad
> Date: 2005-08-16 01:53:20 +0000 (Tue, 16 Aug 2005)
> New Revision: 9314
> WebSVN:
> Log:
>  r5436 at buttercup:  j0j0 | 2005-08-15 20:01:21 -0600
>  libnet_JoinDomain() should honour LIBNET_JOIN_TORTURE now. 
>  torture_join_domain() should properly use libnet_JoinDomain().
>  dssync.c uses torture_join_domain() again.

The only problem I still see is that we probably don't want the
distraction of the torture code in libnet_Join_primary_domain().  

This code puts the details in the tdb, which we don't want for the
torture join (as it is just a 'run time' join).

Also, you need to (for the torture only) delete and re-add the machine -
this ensures we always start with a blank slate.

Perhaps the solution to the 'mess' of the need to keep the SAMR pipe
open is to talloc_steal() it onto an appropriate context for the caller
to deal with.  It then disappears when they talloc_free() the whole lot,
in the normal course of events, or the caller grabs it and places it
somewhere safe.

Andrew Bartlett

Andrew Bartlett                      
Samba Developer, SuSE Labs, Novell Inc.
Authentication Developer, Samba Team 
Student Network Administrator, Hawker College
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url :

More information about the samba-technical mailing list