Bug & fix: call_trans2open returns some parameter fields wrong, causing client operations to fail

Jeremy Allison jra at samba.org
Thu Aug 11 22:44:30 GMT 2005

On Sat, Aug 06, 2005 at 01:04:50PM +0200, samba.10.maazl at spamgourmet.com wrote:
> OS/2 Client application (e.g. FC/2) sometimes fails to create a new file 
> on a samba share reporting "access denied".
> Reason:
> The (final) reply to trans2open leaves the parameter fileds open_access 
> (offset 12) and open_type (offset 14) uninitialized. So the original 
> values from the initial request are returned.
> Fix:
> - Return open_mode (=deny_mode) as open_access like Windows does.
> - Clear open_type. This seems to be right for plain files. Most likely 
> we must return something different here when opening sequential devices 
> like pipes or character devices.
> See attached diff.

Correct - thanks ! It was a typo when I moved to the new map_open_params_to_ntcreate()
code. Thanks a lot.


More information about the samba-technical mailing list