[PATCH][SAMBA_3_0] build diffs for macosx
jra at samba.org
Wed Aug 10 05:45:49 GMT 2005
On Wed, Aug 10, 2005 at 06:53:38AM +1000, Andrew Bartlett wrote:
> On Tue, 2005-08-09 at 13:43 -0700, Steffond P Jones wrote:
> > Andrew,
> > could you merge in the following patch to the SAMBA_3_0 branch to resolve
> > the build issues on mac os x.
> The patch looks good, except for the not implemented functions. For
> krb5_locate_kdc(), I would like to get the feeling of the list for
> removing it entirely. It is *only* used by 'net lookup kdc', and I'm
> told that we get the calling convention of this internal function wrong
> in many cases: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=200342
> As the KDC list will always match the LDAP server list in AD, I would
> prefer to remove this function rather than cludge around it again.
> On the set enctypes function, I wonder if we should fail to compile if
> we can't set them, rather than have a harder to diagnose runtime error
> (so use #error as per other examples in that file).
The patch seems ok - but please don't merge it "as is" until I've
had time to go over it *very* carefully, especially w.r.t. the changes
to the xattr functions.
Looks good at first glance though Steffond, thanks !
More information about the samba-technical