samba4: wrong SERVICE_STATE_ALL constant in svcctl.idl

Karl Melcher kmelcher at gmail.com
Thu Apr 28 09:33:45 GMT 2005


Tim,

Each service is one or the other, but since we are enumerating the
services,  this allows us to filter the ones we want to see.  The MS
Platform SDK uses an "or" of active and inactive bit masks (winsvc.h)
in cases where we want to see them all.

Thanks for checking it in.

Karl



On 4/27/05, Tim Potter <tpot at samba.org> wrote:
> On Wed, 2005-04-27 at 13:48 -0400, Karl Melcher wrote:
> > The constant:
> >       const int SERVICE_STATE_ALL      = 0x00;
> > in librpc/idl/svcctl.idl (around line 47) should have a value of 3.
> > This is the "or" of
> >         SERVICE_STATE_ACTIVE   = 0x01;
> >         SERVICE_STATE_INACTIVE = 0x02;
> >
> > This will greatly affect the quantity of service stati returned by the
> > dcerpc_svcctl_EnumServicesStatus calls.
> 
> I'm not sure it's the logical or of active and inactive (what does being
> both active and inactive mean?) but it's the correct value for that
> constant.
> 
> Thanks for spotting it.  I've checked the change in.
> 
> 
> Tim.
> 
> 
>


More information about the samba-technical mailing list