Fix for setatr in clifile.c

John H Terpstra jht at Samba.Org
Tue Apr 26 15:11:57 GMT 2005


On Tuesday 26 April 2005 09:05, Satwik Hebbar wrote:
> Hey,
>
> I was using the cli_setatr function of the smbclient for setting file
> attributes on a file and the cli_setattrE function for setting timestats
> on the file. Both the functions were converting times to the dos format
> before putting them onto the wire. While this works fine for setattrE,
> setatr, which accepts a time_t value for the last write time for the file,
> sets the incorrect last write value on the file. This is because setatr
> expects times in the unix format and when I made that change to the code,
> it started setting the proper last write time value.
>
> How do I submit the patch for this one? And how does it get verified?

Please submit a bug report with your patch to https://bugzilla.samba.org
so that someone will act on this. Thanks for the diagnositic work you have 
done.

- John T.
-- 
John H Terpstra
Samba-Team Member
Phone: +1 (650) 580-8668

Author:
The Official Samba-3 HOWTO & Reference Guide, ISBN: 0131453556
Samba-3 by Example, ISBN: 0131472216
Hardening Linux, ISBN: 0072254971
Other books in production.


More information about the samba-technical mailing list