Samba4 talloc in Samba3?
Volker.Lendecke at SerNet.DE
Mon Apr 25 07:29:08 GMT 2005
On Sun, Apr 24, 2005 at 02:10:32PM -0700, Jeremy Allison wrote:
> This is a very small change with very large semantic differences underneath
> :-). In the words of "Marathon man"... "is it safe ?" :-) :-).
That's the big question why I did not right away commit it...
> The only place talloc_destroy_pool is definately needed is in
> print_notify_send_messages() to ensure all pending messages get cleaned up
> after send. You could replace this with a talloc_destroy() followed by a
> re-initialization on the send_ctx.
If you had looked at the patch ... :-)
> How much have you valgrinded etc. this ?
Obviously I did not excercise all calls to talloc. I played around with windows
explorer, rpcclient, net etc. Nothing really organized. The result was as
valgrind-clean as before. One or two ones from deep inside nss_ldap, but to get
rid of those is a bit more difficult. :-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20050425/3eb579f2/attachment.bin
More information about the samba-technical