svn commit: samba r6426 - in branches/SAMBA_4_0/source/torture/libnet: .

Rafal Szczesniak mimir at
Fri Apr 22 15:08:55 GMT 2005

On Fri, Apr 22, 2005 at 11:40:40PM +1000, Andrew Bartlett wrote:
> On Fri, 2005-04-22 at 12:30 +1000, Rafal Szczesniak wrote:
> The Samba4 coding style is, as I understand it, that we should never
> discard braces.  It is too easy to either us a macro (which expands to
> more than one statement, and may not be guarded as a while (0)), or
> simply to add another line, particularly if you keep the indentation but
> forget to add the braces.

I'm not worried about the indentation because it never caused me any
trouble in this area, but macro issue is definately a sensible argument.
You convinced me :) I'm putting it back as it was before.

> Lines are cheap, bugs are expensive :-)

Agreed :)

Rafal Szczesniak
Samba Team member

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :

More information about the samba-technical mailing list