[linux-cifs-client] Re: remapping illegal file characters

Dave Kleikamp shaggy at austin.ibm.com
Fri Apr 8 13:18:59 GMT 2005

On Thu, 2005-04-07 at 22:52 -0500, Steve French wrote:
> I would appreciate one or two of you all reviewing the patch though (it 
> got quite large since it hit all file name related string conversions - 
> and since I did not have a pointer to the superblock flags - it hit the 
> parent function(s) in many cases as well).

I think as long as you were changing all of those function prototypes,
it would be a lot cleaner to pass cifs_sb all the way through to
cifsConvertToUCS, rather than have all the callers pass
cifs_sb->local_codepage and (cifs_sb->mnt_cifs_flags &

> 1st part
> http://cifs.bkbits.net:8080/linux-2.5cifs/gnupatch@4250bbcbPSkXcU2T_ZV808KzyzpLqg
> 2nd part
> http://cifs.bkbits.net:8080/linux-2.5cifs/gnupatch@4254b806_RdGWJqoKe3vkf2Ed0X3_A
> 3rd part
> http://cifs.bkbits.net:8080/linux-2.5cifs/gnupatch@4255fd3a1I9WAFEXnUEtEw1WN-_1VA

David Kleikamp
IBM Linux Technology Center

More information about the samba-technical mailing list