svn commit: samba r6182 - in branches/SAMBA_4_0/source/librpc/ndr: .

[Richard Sharpe]

On Mon, 4 Apr 2005, Stefan (metze) Metzmacher wrote:

> sharpe at samba.org schrieb:
> | Author: sharpe
> | Date: 2005-04-03 03:58:45 +0000 (Sun, 03 Apr 2005)
> | New Revision: 6182
> |
> | WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6182
> |
> | Log:
> |
> | Jelmer, I think we need to initialize the switch_list, else we are
> | crash city.
[Deletia ...]
> |  	ndr->depth = 1;
> |  	ndr->flags = 0;
> | +	ndr->switch_list = talloc(ndr, struct ndr_token_list);
> | +	if (!ndr->switch_list)
> | +		goto fail;
>
> I can't see how this can fix the problem, when we initialize a pointer with another
> uninitialized struct...

Sigh, yeah, I didn't look at what DLIST_ADD was doing ...

Regards
-----
Richard Sharpe, rsharpe[at]richardsharpe.com, rsharpe[at]samba.org,
sharpe[at]ethereal.com, http://www.richardsharpe.com