load goes up with 3.0.7

Jeremy Allison jra at samba.org
Wed Oct 20 18:25:50 GMT 2004

On Tue, Oct 12, 2004 at 06:33:10PM +0200, Heinrich Mislik wrote:
Content-Description: Mail message body
> Hi,
> after installing 3.0.7 the load was considerably higher then before. 
> I think one reason is the use of realpath in reduce_name. realpath 
> needs getwd for a relative path, which can be expensive, when it 
> encounters large directories. Attached is a patch, that always passes 
> absolut pathes to realpath. It does so by calling vfs_GetWd and 
> prepending the result. vfs_GetWd does caching and is much faster then 
> calling getwd every time. 
> I did some testing and found that it works, but don't dare to put it 
> into production. Can someone who has more insight comment on this?

The realpath code is only used if symlinks = no or wide links = no.
I'm kind of inclined to think a performance hit is acceptable to
ensure correctness in these cases (people who set these parameters
are more concerned about client leakage out of the share than speed, IMHO
of course).


More information about the samba-technical mailing list