svn commit: samba r2981 - in branches/SAMBA_4_0/source/lib/tdb/common: .

tridge at samba.org tridge at samba.org
Fri Oct 15 04:45:30 GMT 2004


Jeremy,

 > Fix incorrect locks/unlocks in tdb_lockkeys()/tdb_unlockkeys().
 > Spotted by Taj Khattra <taj.khattra at gmail.com>.

This raises the obvious question of why we have these functions at
all. You seemed to add them in December 2000 as part of a merge from
Sourceforge tdb, but they have been completely broken since being
introduced, and Samba has never used them. So why don't we just remove
them and simplify the code?

Cheers, Tridge


More information about the samba-technical mailing list