tdb lockkeys/unlockkeys

Taj Khattra taj.khattra at gmail.com
Sun Oct 10 06:04:54 GMT 2004


hi,

samba-3.0.6 (but i think the bug is present in all versions of tdb)

in tdb_lockeys(), i think
        tdb_lock(tdb, i, F_WRLCK)
should instead be
        tdb_lock(tdb, BUCKET(tdb->lockedkeys[i+1]), F_WRLCK)
and
        tdb_unlock(tdb, j, F_WRLCK)
should instead be
        tdb_unlock(tdb, BUCKET(tdb->lockedkeys[j+1]), F_WRLCK)

similary, in tdb_unlockkeys, i think
        tdb_unlock(tdb, tdb->lockedkeys[i+1], F_WRLCK)
should instead be
        tdb_unlock(tdb, BUCKET(tdb->lockedkeys[i+1]), F_WRLCK)

??

thanks

-taj


More information about the samba-technical mailing list