SMB trans2 set posix acl failure to very current Samba 3

[Jeremy Allison]

On Mon, Nov 29, 2004 at 11:11:04PM -0600, Steve French wrote:
> Getting a failure (probably Samba getting invalid argument in call to 
> acl_clear_perms) setting posix acls to current Samba 3 from svn on very 
> current Linux cifs client test code (from bk tree).  Operation:
> 
>    setfacl -m u:ftp:r /mnt/tmp/patch-2.6.10-rc2
> 
> as owner of file.  Seems to fail on every file I try.  smbd level 10 log 
> follows:
> 
> [2004/11/29 22:57:20, 3] smbd/trans2.c:call_trans2setfilepathinfo(3302)
>  call_trans2setfilepathinfo(6) tmp/patch-2.6.10-rc2 (fnum -1) 
> info_level=516 totdata=56
> [2004/11/29 22:57:20, 8] smbd/dosmode.c:dos_mode(283)
>  dos_mode: tmp/patch-2.6.10-rc2
> [2004/11/29 22:57:20, 8] smbd/dosmode.c:dos_mode_from_sbuf(151)
>  dos_mode_from_sbuf returning
> [2004/11/29 22:57:20, 8] smbd/dosmode.c:dos_mode(315)
>  dos_mode returning
> [2004/11/29 22:57:20, 1] smbd/posix_acls.c:unix_ex_wire_to_permset(3404)
>  unix_ex_wire_to_permset  errno 22 Invalid argument on 
> VFS_SYS_ACL_CLEAR_PERMS

I spoke too soon :-). Looks like a simple error in the server
code (you need to *get* a permset_t pointer from the entry before
any of the permset code will accept it as a valid value). I've
fixed this in SVN for 3.0 and HEAD. Please check out and try
again. Thanks again for testing !

Jeremy.