[Patch] make "net ads changetrustpw" not abort

Jay Fenlason fenlason at redhat.com
Tue Nov 16 20:52:31 GMT 2004


On Fedora Core 3, or other systems where free()ing a static array
causes an abort, "net ads changetrustpw" aborts.  I checked the other
places where generate_random_str() is called, and none of them attempt
to free the static buffer it returns.

This patch fixes it:

--- samba-3.0.9/source/libads/#util.c~	2004-11-16 15:16:02.000000000 -0500
+++ samba-3.0.9/source/libads/util.c	2004-11-16 15:18:12.000000000 -0500
@@ -62,7 +62,6 @@
 failed:
 	SAFE_FREE(service_principal);
 	SAFE_FREE(password);
-	SAFE_FREE(new_password);
 	return ret;
 }
 #endif



More information about the samba-technical mailing list