only 32 users in group member list

[Jonas Olsson]

On Thu, 6 May 2004, Jerome Borsboom wrote:

> In the function add_uid_to_array_unique() in the file
> srv_samr_nt.c, a limit is set on maximum number of uid's in the
> list. This limit is set from groups_max().
>
> However, this due to this limit, the list of users in a group
> will get truncated to this maximum. In usrmgr.exe this will show
> up as users not being member of a group, when they in fact are.
>
> Unless there is a reason to maintain this limit, I propose to
> remove it.
>
>
> Greetz,
> Jerome Borsboom

This bug is still present in the released 3.0.5pre1 and in Subversion. It
seems to have been introduced in revision 116 of
SAMBA_3_0/source/rpc_server/srv_samr_nt.c. Here is a quick patch to remove
the lines causing the bug (for Samba 3.0.5pre1):

----------------- snip -------------------
--- source/rpc_server/srv_samr_nt.c.orig        2004-05-28 21:23:04.000000000 +0200
+++ source/rpc_server/srv_samr_nt.c     2004-05-28 21:23:17.000000000 +0200
@@ -3245,9 +3245,6 @@
 {
        int i;

-       if ((*num) >= groups_max())
-               return;
-
        for (i=0; i<*num; i++) {
                if ((*uids)[i] == uid)
                        return;
----------------- snip -------------------

Is there a any reason to have some kind of check there?

Sincerely,

  /Jonas Olsson