yet another memory leak in winbindd

Jeremy Allison jra at samba.org
Wed May 26 23:59:47 GMT 2004


On Fri, May 07, 2004 at 11:34:26PM +0900, kawasa_r at itg.hitachi.co.jp wrote:
> If gidNumber and uidNumber is undefined when winbind daemon is started,
> winbind daemon leaks some memory. 
> The following patch added free management.
> 
> Index: samba-302/source/sam/idmap_ldap.c
> ===================================================================
> RCS file: /cvs/samba-302/source/sam/idmap_ldap.c,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -r1.4 -r1.5
> 750c750,755
> < 		rc = smbldap_modify(ldap_state.smbldap_state, lp_ldap_idmap_suffix(), mods);
> ---
> > 		if (mods) {
> > 			rc = smbldap_modify(ldap_state.smbldap_state, lp_ldap_idmap_suffix(), mods);
> > 			ldap_mods_free( mods, True );
> > 		} else {
> > 			return NT_STATUS_UNSUCCESSFUL;
> > 		}

Applied, thanks !

Jeremy.


More information about the samba-technical mailing list