Removing OPLOCK check in sendfile processing (source/smbd/reply.c) increases speed

Jeremy Allison jra at samba.org
Tue May 4 00:26:03 GMT 2004


On Tue, May 04, 2004 at 10:21:30AM +1000, Andrew Bartlett wrote:
> 
> So, this is still a bug, as what we should do here (I think, but others
> more involved in this code should comment) is obtain our own oplock, for
> the purpose of calling sendfile.

Actually, W2k doesn't do this (as tridge and I worked out on the
train back from SambaXP 2 years ago) so it's safe to always use
sendfile and send zeros if the file was truncated under us. We
just havn't put that code in yet.

Jeremy.


More information about the samba-technical mailing list