Is this a bug ?

Michael B Allen mba2000 at ioplex.com
Tue Jul 27 03:25:43 GMT 2004


Jack J said:
> Hello,
>
> Looking at file net.c:
>
> <..clipped..>
>
> BOOL net_find_server(unsigned flags, struct in_addr
> *server_ip, char **server_name)
> {
>
>     if (opt_host) {
>         *server_name = strdup(opt_host);
>     }
>
>     if (opt_have_ip) {
>         *server_ip = opt_dest_ip;
>         if (!*server_name) {
>             *server_name =
> strdup(inet_ntoa(opt_dest_ip));
>         }
>
>   ^^^^^^^^^^^^
> why does the code covert IP address to ascii ?

This is not a bug. A lot of remote management functions take a
"servername" argument (see api docs on msdn). The above code looks like
it's just falling back to a dot-quad ip servername if a regular one cannot
be determined.

Mike


More information about the samba-technical mailing list