[PATCH] make 'required_membership_sid' accessible for pam_winbind

Andrew Bartlett abartlet at samba.org
Wed Jul 14 07:43:54 GMT 2004

On Wed, 2004-07-14 at 17:25, Guenther Deschner wrote:
> Hi,
> On Tue, Jul 13, 2004 at 11:30:07PM +1000, Andrew Bartlett wrote:
> > > The way get_user_sids gets all sids for the user is not very well done, I'm
> > > afraid. How could it be done cleaner?
> >
> > Yes, it looks ugly.  Why do you have a name->sid call in there?  The
> > existing code already shows how to create a user sid from the RID in the
> > info3 reply.
> Does it look better now?

Close, but it still looks like it generates network traffic.

This is a very, very often called API, so I don't want to go out to the
network again, and my understanding is that we can figure out these
details just out of pdb.

Andrew Bartlett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20040714/f1c169c9/attachment.bin

More information about the samba-technical mailing list