Patch for printers browser, samba3.0.2pre1
Gerald (Jerry) Carter
jerry at samba.org
Sat Jan 31 21:34:52 GMT 2004
-----BEGIN PGP SIGNED MESSAGE-----
Andrew Bartlett wrote:
| It didn't work (or later broke) but I remember when tpot removed this,
| and added:
yes, yes, yes....I remember it too. but no one ever tested it.
nmbd doesn't load the services before send_host_announcement()
so lp_add_printer() was never called so the flag was never set.
I tried a different variation enumeration over the services in
set_default_server_announcement_type() but lp_numservices()
returns 0 in nmbd.
I spoke with Jeremy without digging too deeply we agreed
this was a quick fix for now and we need a proper fix in
nmbd that allows us to conditionaly set this flag.
Remember that "untested changes are broken changes" which
seems to have been the case here.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the samba-technical