CVS update: samba4/source/lib/popt
Stefan (metze) Metzmacher
metze at samba.org
Tue Feb 24 09:55:40 GMT 2004
> On Tue, 2004-02-24 at 17:49, Stefan Metzmacher wrote:
>> Date: Tue Feb 24 06:49:59 2004
>> Author: metze
>>
>> Update of /home/cvs/samba4/source/lib/popt
>> In directory dp.samba.org:/tmp/cvs-serv303/lib/popt
>>
>> Modified Files:
>> findme.c popt.c poptconfig.c popthelp.c poptparse.c
>> Log Message:
>> let the popt replacement stuff survive a make proto
>
> This seems compleatly the wrong approach. Why not simply make 'make
> proto' skip these files. Then we don't waste build time on files we
> know we will skip.
>
> Ok, that was a bad argument, but the real issue is that we should be
> able to drop in a new popt version, and the unmodified files should
> work. Remember, popt is externally provides, as is ubiqx. Both already
> provide the required headers.
I agree here in all points:-)
And this is just temporary solution, to fix the build,
I'll change make proto to create one file per subsystem, if it's selected in
the SMB_SUBSYSTEM() macro in the config.m4 file, or skip the proto header
for the subsystem...
--
metze
Stefan Metzmacher <metze at samba dot org>
More information about the samba-technical
mailing list