Our lsa_lookup_sids returns wrong unmapped names

[Jeremy Allison]

On Mon, Feb 16, 2004 at 11:34:44PM +0100, Volker.Lendecke at SerNet.DE wrote:
> Hi!
> 
> When lsa_lookup_sids is asked for an unmapped sid we return something different
> from Windows. And our own client code depends on the Windows behaviour...
> 
> For unmapped SIDs at least NT4 returns the sid in string form and -1 as the
> domain index. We return NULL as a name and 0 as the domain index. Neither
> rpcclient nor net like that.
> 
> See the attached sniffs and the patch to modify Samba's behaviour to match NT4.
> I'm too tired to directly commit it, could someone else look at it?

This looks correct, but we also need to return STATUS_SOME_UNMAPPED as
well if mapped_count != num_entries/ I have a varient of this I will
commit.

Thanks !

Jeremy.