libsmbclient: parsing of domain/workgroup in smbc_parse_path not performed.

[Andrew Bartlett]

On Tue, 2004-02-10 at 01:07, Richard Sharpe wrote:
> On Mon, 9 Feb 2004, Lautier, Marc wrote:
> 
> > I'm currently working on some customization of the libsmbclient.
> > 
> > I noticed that the smbc_parse_path function, which is supposed to decode
> > URLs with the format:
> > 	smb://[[[domain;]user[:password]@]server[/share[/path[/file]]]]
> > 
> > does in fact totally ignore the domain field.
> > 
> > Instead from being parsed from the URL (when present), that information
> > seems to be copied directly from the context workgroup field, or the
> > authentication function.
> > 
> > Is there is specific reason NOT to retrieve that information from the URL
> > when it is present ?
> 
> Probably that I forgot to do that properly when I wrote the code.

If the user was in the form domain\user (possibly escaped correctly)
then it would pass to our internal code that splits it up.

I have always objected to the idea of domain;user - it just seems so
stupid...  (And so completely ignores the existing standards in this
area)

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20040210/9806e4dc/attachment.bin