CVS update: samba/source/lib

Andrew Bartlett abartlet at
Wed Feb 4 07:50:37 GMT 2004

On Wed, 2004-02-04 at 13:09, jra at wrote:
> Date:	Wed Feb  4 02:09:43 2004
> Author:	jra
> Update of /data/cvs/samba/source/lib
> In directory
> Modified Files:
> 	charcnv.c iconv.c 
> Log Message:
> Working on #830. Cope with bad conversions better - don't just memcpy but
> try a crap conversion instead. Next this needs to be done to the convert_alloc
> function.
> Actually fixes some valgrind warnings as well - cool !
> Jeremy.

Thanks for working on this.  

I'm wondering if we can have a good (not just watching errno) method for
the caller to tell if this has occurred.  My hope is that we can setup
our name mangling code to mangle all names that do not perfectly convert
to UCS2.  (With the natural fast-paths for ASCII).  This would ensure we
don't give these 'half converted' names to clients, much as we do not
give other 'bad' names.

Similarly, fnmatch()/strcasecmp should use this in determining if a
string matches.

Andrew Bartlett

Andrew Bartlett                                 abartlet at
Manager, Authentication Subsystems, Samba Team  abartlet at
Student Network Administrator, Hawker College   abartlet at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url :

More information about the samba-technical mailing list