is_locked optimization

Jeremy Allison jra at samba.org
Thu Dec 9 22:09:27 GMT 2004


On Fri, Dec 03, 2004 at 12:17:55AM +0200, Nadav Danieli wrote:
> Oops, sorry, forgot to attach the diff :-)
> 
> On Fri, 2004-12-03 at 00:09, Nadav Danieli wrote:
> 
> > Hello all,
> > 
> > When reading/writing file with locking and strict locking (default)
> > enabled, is_locked is called. I have very little knowledge about tdb
> > overhead, but it seems that if oplock is granted, unnecessary (to me,)
> > to call brl_locktest.
> > Attached is a suggested change for is_locked in cases an oplock is
> > granted.
> > I would like to hear any opinion regarding this change, and of course,
> > if it is wrong.

Nope - looks a good idea to me (with some testing of course). I'll commit it
into the SVN for the next release !

Thanks,

	Jeremy.


More information about the samba-technical mailing list