svn commit: samba r2133 - in branches/SAMBA_3_0/source: include libmodules printing rpc_server rpcclient

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Reilly, John R. (ProCurve Networking) wrote:
| Jerry -
|
| This stuff (alignment bug) is such a pain! How did you figure the
| reorder idea?
|
|    * Work around parsing error in the print change notify code
|      (not that the alignment bug is still there but reording the
|       entries in the array works around it).

Laziness mostly.  The job submission date is always 4 x uint16
IIRC so the problem was alignment after a UNISTR2.  I don't
think that the submssion time should be marshalled as a string,
but the current parsing code doesn't allow for this distinction
currently. Placing the submission time string at the beginning
just ensured that the submission data buffer was aligned correctly
(on a 2 byte boundary, not 4 byte one).




cheers, jerry
- ---------------------------------------------------------------------
Alleviating the pain of Windows(tm)      ------- http://www.samba.org
GnuPG Key                ----- http://www.plainjoe.org/gpg_public.asc
"If we're adding to the noise, turn off this song"--Switchfoot (2003)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBNKXiIR7qMdg1EfYRAizmAKDcpFMzKdBZhSRCo0C0zvu5rmRlTACfYca9
8KUTy3p/8UwmIwTzTrfOGdQ=
=+wbF
-----END PGP SIGNATURE-----