svn commit: samba r1845 - in branches/SAMBA_4_0/source: build/pidl librpc/rpc

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

tridge at samba.org schrieb:
| Metze,
|
|  >  	if (dce_call->fault_code != 0) {
|  > -		return NT_STATUS_NET_WRITE_FAULT;
|  > +		return dcerpc_map_fault2ntstatus(dce_call->fault_code);
|
| I'm a bit concerned about this API change. The way I meant this to
| work is that NT_STATUS_NET_WRITE_FAULT from a DCE/RPC call means "you
| got a DCE/RPC fault, please look at the fault code in
| p->last_fault_code".

Ok, I'll revert this and add a dcerpc_fault_str() function which will be
like nt_errstr() so that the torture tests can use this.

I reason I add that one was that I was always confused when I got
NT_STATUS_NET_WRITE_FAULT, when I typed th wrong password, or for
running against samba4 when a function was not implemented...

For me NT_STATUS_NET_WRITE_FAULT always sounds like
"Your IDL is wrong!!!"


- --
metze

Stefan Metzmacher <metze at samba.org> www.samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3-nr1 (Windows XP)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFBIu8nm70gjA5TCD8RAmpWAJsGTLTJ++9iZ/GMwTxkLNMsZuERHwCghPAW
VBj0xAG9k97s9e3TxFJZhoQ=
=Pmt4
-----END PGP SIGNATURE-----