[PATCH] disable sendfile on ENOSYS

James Peach jpeach at sgi.com
Mon Aug 9 02:21:11 GMT 2004

On Fri, Aug 06, 2004 at 09:04:59AM -0400, Michael Sweet wrote:
> James Peach wrote:
> >Hi all,
> >
> >The attached patch flips the "use sendfile" parameter off if we find
> >out at runtime that it sendfile isn't present or doesn't work (ie. we
> >get an ENOSYS for it).
> I think a log message would also be appropriate when you turn
> the sendfile support off - that way the administrator knows that
> something happened... :)

I thought about it but decided not to on the basis that there was no
print in the existing fallback path and set_store_dos_attributes
doesn't do it (ie. appeal to precedent :). It might have been worth
logging this at some fairly low level, though.

James Peach | jpeach at sgi.com | SGI Australian Software Group
I don't speak for SGI.

More information about the samba-technical mailing list