Fix for localgroup deleting using usrmgr, samba-3.0.3pre2
Jianliang Lu
j.lu at tiesse.com
Tue Apr 20 13:07:34 GMT 2004
This fix solve the localgroup deleting problem (ACCESS DENIED), using
usrmgr. The same fix applied for _samr_delete_dom_group some times ago for
global group deleting.
FIXME:
--- samba-3.0.3pre2/source/rpc_server/srv_samr_nt.c.orig Thu Apr 15
15:25:26 2004
+++ samba-3.0.3pre2/source/rpc_server/srv_samr_nt.c Tue Apr 20 14:46:41 2004
@@ -3854,6 +3854,10 @@
if ( (grp=getgrgid(gid)) == NULL)
return NT_STATUS_NO_SUCH_ALIAS;
+ /* delete mapping first */
+ if(!pdb_delete_group_mapping_entry(alias_sid))
+ return NT_STATUS_ACCESS_DENIED;
+
/* we can delete the UNIX group */
smb_delete_group(grp->gr_name);
@@ -3861,9 +3865,6 @@
if ( (grp=getgrgid(gid)) != NULL)
return NT_STATUS_ACCESS_DENIED;
- /* don't check if we removed it as it could be an un-mapped group */
- pdb_delete_group_mapping_entry(alias_sid);
-
if (!close_policy_hnd(p, &q_u->alias_pol))
return NT_STATUS_OBJECT_NAME_INVALID;
Jianliang Lu
TieSse s.p.a. Ivrea (To) - Italy
j.lu at tiesse.com luj at libero.it
http://www.tiesse.com
More information about the samba-technical
mailing list