smb_iconv modifies constant input strings

Jeremy Allison jra at samba.org
Sat Sep 27 01:29:19 GMT 2003


On Fri, Sep 26, 2003 at 06:09:20PM -0700, Matt Seitz wrote:
> The "smb_iconv" function takes a "const char **" input string argument, but then 
> passes the input string to "iconv", which modifies the input string.  This led 
> to unexpected data corruption in some code I wrote that called "smb_iconv".
> 
> Could "smb_iconv" be modified to either:
> 
> a) declare its input string argument as "char **", or

Fixed for 3.0.1 (in SAMBA_3_0 CVS). Thanks,

Jeremy.



More information about the samba-technical mailing list