smb_iconv modifies constant input strings

Jeremy Allison jra at
Sat Sep 27 01:20:21 GMT 2003

On Sat, Sep 27, 2003 at 11:17:16AM +1000, Andrew Bartlett wrote:
> Neither of these options are very good.  Samba's use of iconv() really
> does assume it behaves in the way descriped in the linux manpage - which
> declares it as char ** input, but does not modify the input string.  

I'm not so sure. Changing smb_iconv to take a char **, not const char **
seems the easiest. If iconv does behave this way then we need to honour
that interface.


More information about the samba-technical mailing list