bug in winbind causes local user be authenticated as domain user in 3.0.0rc1

[Jeremy Allison]

On Wed, Sep 17, 2003 at 01:13:34PM -0400, Lin Li wrote:
> Hi,
> 
> I found a bug in winbind which causes a local user be authenticated as a 
> domain user. I'm using 3.0.0rc1.
> 
> Here is the patch:
> ----------------------------------------------------------------------------------------------------
> --- winbindd_pam.c.old  2003-09-17 13:09:02.000000000 -0400
> +++ winbindd_pam.c      2003-09-17 13:09:19.000000000 -0400
> @@ -94,7 +94,7 @@
>         /* Parse domain and username */
> 
>         parse_domain_user(state->request.data.auth.user, name_domain, 
> name_user);
> -       if ( !name_domain ) {
> +       if ( !*name_domain ) {
>                 DEBUG(5,("no domain separator (%s) in username (%s) - 
> failing auth\n", lp_winbind_separator(), state->request.data.auth.user));
>                 result = NT_STATUS_INVALID_PARAMETER;
>                 goto done;
> ------------------------------------------------------------------------------------------------------

Good catch - thanks. Applied.

Jeremy.