CVS update: samba/source/libsmb

Andrew Bartlett abartlet at samba.org
Tue Sep 16 06:28:05 GMT 2003


On Tue, Sep 16, 2003 at 06:04:18AM +0000, Jeremy Allison wrote:
> On Tue, Sep 16, 2003 at 01:36:57PM +1000, Andrew Bartlett wrote:
> > On Tue, Sep 16, 2003 at 01:27:46AM +0000, jra at samba.org wrote:
> > > 
> > > Date:	Tue Sep 16 01:27:46 2003
> > > Author:	jra
> > > 
> > > Update of /data/cvs/samba/source/libsmb
> > > In directory dp.samba.org:/tmp/cvs-serv23059/libsmb
> > > 
> > > Modified Files:
> > >       Tag: SAMBA_3_0
> > > 	cliconnect.c ntlmssp.c 
> > > Log Message:
> > > Fix #442 which Alexander considered a showstopper. Allow us to join mixed
> > > mode domains.
> > > Jeremy.
> > 
> > Why did you remove the NTLMv2 code?  I'm assuming it was just a cut&paste
> > bug.
> > 
> > -	ntlmssp_state->use_ntlmv2 = lp_client_ntlmv2_auth();
> > 
> > By removing this, we will never do NTLMv2 on an NTLMSSP connection.
> 
> Nope, if you look at the code in libsmb/ntlmssp.c we already do this in
> the ntlmssp_client_start() call above. The call in this
> function is redundant.
> 
> See the code at line 668 in libsmb/ntlmssp.c

OK, I admit to not knowing my own code :-)

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net



More information about the samba-technical mailing list